linux-kernel - Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74f19f24-fc6a-748d-3778-26ee0bfb2d40@gmx.de>
Date:   Tue, 7 Aug 2018 22:30:53 +0200
From:   Helge Deller <deller@....de>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     dave.anglin@...l.net, jejb@...isc-linux.org,
        Nathan Chancellor <natechancellor@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Pravin Shedge <pravin.shedge4linux@...il.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        linux-parisc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Alistair Strachan <astrachan@...gle.com>
Subject: Re: [PATCH] parisc: prefer _THIS_IP_ and _RET_IP_ statement
 expressions

On 07.08.2018 20:11, Nick Desaulniers wrote:
> On Fri, Aug 3, 2018 at 3:34 PM Helge Deller <deller@....de> wrote:
>> So, your patch is basically OK and doesn't break anything.
>> But I agree with Dave and Andrew, that THIS_IP is ugly.
> 
> I don't disagree, and other maintainers have remarked on _THIS_IP_
> being ugly, but renaming it en masse is a tree wide change, which I'm
> trying to avoid at the moment.

Understandable.

> It sounds like we have a working patch? Are there 64b parisc machines
> to test on, or can this get merged?

Go ahead and merge it.

In addition, somehow I'd prefer if there would be a way to add to include/linux/kernel.h:
+#if !defined(_THIS_IP_)
#define _THIS_IP_  ({ __label__ __here; __here: (unsigned long)&&__here; })
+#endif

That way it would somehow be possible to replace that label calulation by the
preferable inline assembly of current_text_address()...

Helge