linux-kernel - Re: [PATCH v5 5/5] Auto-detect whether a FPU exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180809063124.GA26062@infradead.org>
Date:   Wed, 8 Aug 2018 23:31:24 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Alan Kao <alankao@...estech.com>
Cc:     linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <albert@...ive.com>,
        Christoph Hellwig <hch@...radead.org>,
        Andrew Waterman <andrew@...ive.com>,
        Arnd Bergmann <arnd@...db.de>,
        Darius Rad <darius@...espec.com>, greentime@...estech.com,
        vincentc@...estech.com, zong@...estech.com, nickhu@...estech.com
Subject: Re: [PATCH v5 5/5] Auto-detect whether a FPU exists

>  extern unsigned long elf_hwcap;
> +extern bool has_fpu;
>  #endif

Doesn't this conflict with the !CONFIG_CPU stub in switch_to.h?

It seems like we should only have this definition in one place to start
with.

Otherwise this looks fine to me:

Reviewed-by: Christoph Hellwig <hch@....de>