linux-kernel - Re: [PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1f2ab32-ff10-9575-ad61-0286ee3811ae@gmail.com>
Date:   Thu, 9 Aug 2018 19:42:19 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in
 rtw_xmit.c

On 8/9/18 7:13 PM, Joe Perches wrote:
> On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote:
>> Use is_multicast_ether_addr instead of custom IS_MCAST in
>> core/rtw_xmit.c.
> 
> Have you verified that all accesses are __aligned(2) ?
> 
> If so, please state that in the patch description.
> 
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> []
>> @@ -460,10 +460,10 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
>>   	if ((pattrib->ether_type == ETH_P_ARP) || (pattrib->ether_type == ETH_P_PAE) || (pattrib->dhcp_pkt == 1))
>>   		rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_SPECIAL_PACKET, 1);
>>   
>> -	bmcast = IS_MCAST(pattrib->ra);
>> +	mcast = is_multicast_ether_addr(pattrib->ra);
> 
> i.e.:  is pattrib->ra __aligned(2) ?
> 
> etc...
> 

Hi Joe,

I looked at the function comment for is_multicast_ether_addr in etherdevice.h.
There is not mentioned that __aligned(2) is required. If it is, I will check.

So, is it required although it's not mentioned for is_multicast_ether_addr?

Thanks,
Michael