linux-kernel - Re: [PATCH v6 4/4] platform/x86: Add ACPI i2c-multi-instantiate pseudo driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1946404.OiO1uWY7Ot@aspire.rjw.lan>
Date:   Sun, 12 Aug 2018 13:14:23 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Darren Hart <dvhart@...radead.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        linux-i2c <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v6 4/4] platform/x86: Add ACPI i2c-multi-instantiate pseudo driver

On Thursday, August 9, 2018 2:08:41 PM CEST Hans de Goede wrote:
> Hi,
> 
> On 09-08-18 13:55, Rafael J. Wysocki wrote:
> > On Thu, Aug 9, 2018 at 1:40 PM, Hans de Goede <hdegoede@...hat.com> wrote:
> >> On systems with ACPI instantiated i2c-clients, normally there is 1 fw_node
> >> per i2c-device and that fw-node contains 1 I2cSerialBus resource for that 1
> >> i2c-device.
> >>
> >> But in some rare cases the manufacturer has decided to describe multiple
> >> i2c-devices in a single ACPI fwnode with multiple I2cSerialBus resources.
> >>
> >> An earlier attempt to fix this in the i2c-core resulted in a lot of extra
> >> code to support this corner-case.
> >>
> >> This commit introduces a new i2c-multi-instantiate driver which fixes this
> >> in a different way. This new driver can be built as a module which will
> >> only loaded on affected systems.
> >>
> >> This driver will instantiate a new i2c-client per I2cSerialBus resource,
> >> using the driver_data from the acpi_device_id it is binding to to tell it
> >> which chip-type (and optional irq-resource) to use when instantiating.
> >>
> >> Note this driver depends on a platform device being instantiated for the
> >> ACPI fwnode, see the i2c_multi_instantiate_ids list of ACPI device-ids in
> >> drivers/acpi/scan.c: acpi_device_enumeration_by_parent().
> >>
> >> Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >> Acked-by: Wolfram Sang <wsa@...-dreams.de>
> >> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> >> ---
> >> Changes in v2:
> >> -Rebase on top of 4.18-rc2
> >>
> >> Changes in v3:
> >> -Change from an i2c-driver using a hack to allow having multiple i2c clients
> >>   at the same address to a platform-driver
> >>
> >> Changes in v4:
> >> -Tweak MAINTAINERS entry a bit
> >>
> >> Changes in v5:
> >> -s/no_clients/num_clients/
> >> -Change patch Subject prefix to platform/x86
> >>
> >> Changes in v6:
> >> -s/irq_idx/gpio_irq_idx/
> > 
> > And this is the only patch that has changed in v6, right?
> 
> Correct.
> 
> > Anyway, if you have further updates on top of this series, please send
> > them as incremental patches.
> 
> Ok, will do.

The series has been applied, thanks!