linux-kernel - Re: [PATCH] ACPI / EC: Use ec_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1855499.yJd7R0ESNr@aspire.rjw.lan>
Date:   Sun, 12 Aug 2018 13:14:46 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Aaron Ma <aaron.ma@...onical.com>
Cc:     linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH] ACPI / EC: Use ec_no_wakeup on ThinkPad X1 Yoga 3rd

On Tuesday, July 31, 2018 12:52:39 PM CEST Aaron Ma wrote:
> Like on X1C6, on X1Y3 EC interrupts constantly wake up system from
> s2idle, the power consumption is extremely high.
> So make ec_no_wakeup be true as default to keep system in s2idle mode
> and reduce power consumption.
> 
> Power button works when ec_no_wakeup=true.
> 
> Signed-off-by: Aaron Ma <aaron.ma@...onical.com>
> ---
>  drivers/acpi/ec.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 917f77f4cb55..6291d5c77267 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -2045,6 +2045,13 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
>  			DMI_MATCH(DMI_PRODUCT_FAMILY, "Thinkpad X1 Carbon 6th"),
>  		},
>  	},
> +	{
> +		.ident = "ThinkPad X1 Yoga 3rd",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Yoga 3rd"),
> +		},
> +	},
>  	{ },
>  };
>  
> 

Applied, thanks!