linux-kernel - Re: [PATCH] net: Change the layout of structure trace_event_raw_fib_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9697bf5-11eb-68ec-238f-aedb724c8c17@gmail.com>
Date:   Mon, 13 Aug 2018 08:40:32 -0600
From:   David Ahern <dsahern@...il.com>
To:     Zong Li <zong@...estech.com>, rostedt@...dmis.org,
        mingo@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     zongbox@...il.com, greentime@...estech.com
Subject: Re: [PATCH] net: Change the layout of structure
 trace_event_raw_fib_table_lookup

On 8/12/18 8:26 PM, Zong Li wrote:
> There is an unalignment access about the structure
> 'trace_event_raw_fib_table_lookup'.
> 
> In include/trace/events/fib.h, there is a memory operation which casting
> the 'src' data member to a pointer, and then store a value to this
> pointer point to.
> 
> p32 = (__be32 *) __entry->src;
> *p32 = flp->saddr;
> 
> The offset of 'src' in structure trace_event_raw_fib_table_lookup is not
> four bytes alignment. On some architectures, they don't permit the
> unalignment access, it need to pay the price to handle this situation in
> exception handler.
> 
> Adjust the layout of structure to avoid this case.
> 
> Signed-off-by: Zong Li <zong@...estech.com>
> ---
>  include/trace/events/fib.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Fixes: 9f323973c915 ("net/ipv4: Udate fib_table_lookup tracepoint")
Acked-by: David Ahern <dsahern@...il.com>

Do you also need a similar change to fib6_table_lookup in
include/trace/events/fib6.h?