linux-kernel - Re: [PATCH] net: Change the layout of structure trace_event_raw_fib_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180813.093702.2205532109074390272.davem@davemloft.net>
Date:   Mon, 13 Aug 2018 09:37:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zong@...estech.com
Cc:     rostedt@...dmis.org, mingo@...hat.com, dsahern@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        zongbox@...il.com, greentime@...estech.com
Subject: Re: [PATCH] net: Change the layout of structure
 trace_event_raw_fib_table_lookup

From: Zong Li <zong@...estech.com>
Date: Mon, 13 Aug 2018 10:26:52 +0800

> There is an unalignment access about the structure
> 'trace_event_raw_fib_table_lookup'.
> 
> In include/trace/events/fib.h, there is a memory operation which casting
> the 'src' data member to a pointer, and then store a value to this
> pointer point to.
> 
> p32 = (__be32 *) __entry->src;
> *p32 = flp->saddr;
> 
> The offset of 'src' in structure trace_event_raw_fib_table_lookup is not
> four bytes alignment. On some architectures, they don't permit the
> unalignment access, it need to pay the price to handle this situation in
> exception handler.
> 
> Adjust the layout of structure to avoid this case.
> 
> Signed-off-by: Zong Li <zong@...estech.com>

Applied, with Fixes tag from David added.