linux-kernel - Re: [PATCH v2] USB: core: devio: Restructured proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180813182236.GA6582@terrence.localdomain>
Date:   Mon, 13 Aug 2018 19:22:36 +0100
From:   thomas.m.a.todd@...il.com
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Tom Todd <thomas.m.a.todd@...il.com>, joe@...ches.com,
        stern@...land.harvard.edu, dan.carpenter@...cle.com,
        arvind.yadav.cs@...il.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] USB: core: devio: Restructured proc_ioctl for
 readability

On Mon, Aug 13, 2018 at 08:34:55AM +0200, Greg KH wrote:
> On Sun, Aug 12, 2018 at 11:26:54PM +0100, Tom Todd wrote:
> > On, Sun, 12 Aug 2018 11:34:59 -0700 Joe Perches wrote:
> > >On Sun, 2018-08-12 at 19:06 +0100, Tom Todd wrote:
> > >> Fixed a code styling issue
> > >while it's OK to fix style only issues, it's much better
> > >to reorganize the code for reader clarity.
> > 
> > Ok, thank you, I've taken your suggestions and created the a new version
> > 
> > Restructured method proc_ioctl for readability and fixed code style
> > errors.
> 
> Please always be very specific as to exactly what code style issues you
> are fixing.  And never do more than one type of fix at a time, otherwise
> it is hard to review, and you can cause errors to be added, like you did
> here :(
> 
> Please do not start working on code cleanups in any other area of the
> kernel other than drivers/staging/ as that is what that is for.  To do
> so in other areas of the kernel causes more work for maintainers.
> 
> thanks,
> 
> greg k-h
Understood, sorry for the bother caused.

Regards,

Tom Todd