lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Aug 2018 10:02:23 +0300 From: Nikolay Borisov <nborisov@...e.com> To: zhong jiang <zhongjiang@...wei.com>, clm@...com, jbacik@...com, dsterba@...e.com Cc: linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] btrfs:free-space-cache: remove unneeded NULL check before kfree On 13.08.2018 09:06, zhong jiang wrote: > Kfree has taken the null pointer into account. So remove the check > before kfree. > > The issue is detected with the help of Coccinelle. > > Signed-off-by: zhong jiang <zhongjiang@...wei.com> Reviewed-by: Nikolay Borisov <nborisov@...e.com> > --- > fs/btrfs/free-space-cache.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c > index c3888c1..69d639f 100644 > --- a/fs/btrfs/free-space-cache.c > +++ b/fs/btrfs/free-space-cache.c > @@ -2110,8 +2110,7 @@ static int insert_into_bitmap(struct btrfs_free_space_ctl *ctl, > > out: > if (info) { > - if (info->bitmap) > - kfree(info->bitmap); > + kfree(info->bitmap); > kmem_cache_free(btrfs_free_space_cachep, info); > } > > @@ -3605,8 +3604,7 @@ int test_add_free_space_entry(struct btrfs_block_group_cache *cache, > > if (info) > kmem_cache_free(btrfs_free_space_cachep, info); > - if (map) > - kfree(map); > + kfree(map); > return 0; > } > >
Powered by blists - more mailing lists