linux-kernel - Re: [PATCH v2] coccicheck: return proper error code on fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNASH0ypRWi01zUX2WCfG_KkjfLuRNSqhnQFyWAH+6iFHvA@mail.gmail.com>
Date:   Mon, 13 Aug 2018 16:28:04 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Denis Efremov <efremov@...ux.com>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH v2] coccicheck: return proper error code on fail

2018-08-11 5:31 GMT+09:00 Julia Lawall <julia.lawall@...6.fr>:
>
>
> On Fri, 10 Aug 2018, efremov@...ux.com wrote:
>
>> From: Denis Efremov <efremov@...ux.com>
>>
>> If coccicheck fails, it should return an error code distinct from zero
>> to signal about an internal problem. Current code instead of exiting with
>> the tool's error code returns the error code of 'echo "coccicheck failed"'
>> which is almost always equals to zero, thus failing the original intention
>> of alerting about a problem. This patch fixes the code.
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Denis Efremov <efremov@...ux.com>
>
> OK, I get it now.  Thanks.
>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>
>


Applied to linux-kbuild. Thanks!


>> ---
>>  scripts/coccicheck | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index 9fedca611b7f..e04d328210ac 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -128,9 +128,10 @@ run_cmd_parmap() {
>>       fi
>>       echo $@ >>$DEBUG_FILE
>>       $@ 2>>$DEBUG_FILE
>> -     if [[ $? -ne 0 ]]; then
>> +     err=$?
>> +     if [[ $err -ne 0 ]]; then
>>               echo "coccicheck failed"
>> -             exit $?
>> +             exit $err
>>       fi
>>  }
>>
>> --
>> 2.17.1
>>
>>



-- 
Best Regards
Masahiro Yamada