linux-kernel - Re: [PATCH] x86/smp: fix non-SMP broken build due to redefinition of apic_id_is_primary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+55aFyZoZFYztUjqT4m_HLhh4uoBg38ypAsZ3ufTYVnQr4s0w@mail.gmail.com>
Date:   Tue, 14 Aug 2018 15:00:20 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Peter Anvin <hpa@...or.com>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] x86/smp: fix non-SMP broken build due to redefinition of apic_id_is_primary_thread

On Tue, Aug 14, 2018 at 2:39 PM Vlastimil Babka <vbabka@...e.cz> wrote:
>
> The function has an inline "return false;" definition with CONFIG_SMP=n but the
> "real" definition is also visible leading to "redefinition of
> ‘apic_id_is_primary_thread’" compiler error. Guard it with #ifdef CONFIG_SMP

Applied.

                Linus