linux-kernel - Re: [PATCH] perf auxtrace: Fix queue resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180814220702.GB32497@kernel.org>
Date:   Tue, 14 Aug 2018 19:07:02 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf auxtrace: Fix queue resize

Em Tue, Aug 14, 2018 at 11:46:08AM +0300, Adrian Hunter escreveu:
> When the number of queues grows beyond 32, the array of queues is resized
> but not all members were being copied. Fix by also copying 'tid', 'cpu' and
> 'set'.

Thanks, applied.
 
> Fixes: e502789302a6e ("perf auxtrace: Add helpers for queuing AUX area tracing data")
> Cc: stable@...r.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>  tools/perf/util/auxtrace.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index ae8c37b219c9..db1511359c5e 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -203,6 +203,9 @@ static int auxtrace_queues__grow(struct auxtrace_queues *queues,
>  	for (i = 0; i < queues->nr_queues; i++) {
>  		list_splice_tail(&queues->queue_array[i].head,
>  				 &queue_array[i].head);
> +		queue_array[i].tid = queues->queue_array[i].tid;
> +		queue_array[i].cpu = queues->queue_array[i].cpu;
> +		queue_array[i].set = queues->queue_array[i].set;
>  		queue_array[i].priv = queues->queue_array[i].priv;
>  	}
>  
> -- 
> 2.17.1