linux-kernel - Re: [PATCH] usb: hide usb_of_get_companion_dev for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a33DRBj6ZeJBeWGnw3RnpK3rTaYtrbs6jjZ8VVPOk8=qw@mail.gmail.com>
Date:   Tue, 14 Aug 2018 16:26:30 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     gregkh <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        yoshihiro.shimoda.uh@...esas.com, Johan Hovold <johan@...nel.org>,
        USB list <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: hide usb_of_get_companion_dev for CONFIG_USB=n

On Tue, Aug 14, 2018 at 3:58 PM Alan Stern <stern@...land.harvard.edu> wrote:
> On Mon, 13 Aug 2018, Arnd Bergmann wrote:
> > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> > index 0a16cbd4e528..663a8bd67a7b 100644
> > --- a/drivers/usb/gadget/udc/Kconfig
> > +++ b/drivers/usb/gadget/udc/Kconfig
> > @@ -193,6 +193,7 @@ config USB_RENESAS_USB3
> >       tristate 'Renesas USB3.0 Peripheral controller'
> >       depends on ARCH_RENESAS || COMPILE_TEST
> >       depends on EXTCON
> > +     depends on USB || !USB
>
> Is this some weird standard idiom?  It looks really strange.

Yes, and yes.

A less common way to write it is

        depends on (USB != m) || m

which some people prefer, but I find even weirder.

       Arnd