linux-kernel - Re: [PATCH] net: sock_diag: Fix spectre v1 gadget in __sock_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180814.100503.1519932338963499861.davem@davemloft.net>
Date:   Tue, 14 Aug 2018 10:05:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jcline@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jpoimboe@...hat.com, konrad.wilk@...cle.com, jamie.iles@...cle.com,
        liran.alon@...cle.com, stable@...r.kernel.org
Subject: Re: [PATCH] net: sock_diag: Fix spectre v1 gadget in
 __sock_diag_cmd()

From: Jeremy Cline <jcline@...hat.com>
Date: Mon, 13 Aug 2018 22:23:13 +0000

> req->sdiag_family is a user-controlled value that's used as an array
> index. Sanitize it after the bounds check to avoid speculative
> out-of-bounds array access.
> 
> This also protects the sock_is_registered() call, so this removes the
> sanitize call there.
> 
> Fixes: e978de7a6d38 ("net: socket: Fix potential spectre v1 gadget in sock_is_registered")
> Cc: Josh Poimboeuf <jpoimboe@...hat.com>
> Cc: konrad.wilk@...cle.com
> Cc: jamie.iles@...cle.com
> Cc: liran.alon@...cle.com
> Cc: stable@...r.kernel.org
> Signed-off-by: Jeremy Cline <jcline@...hat.com>
> ---
> 
> Since commit e978de7a6d38 didn't apply cleanly to v4.14, this won't
> either since it reverts that change. To apply cleanly there, the change
> to sock_is_registered() needs to be dropped.

Applied, thank you.