linux-kernel - Re: [PATCH] RDMA/bnxt_re: QPLIB: Add and use #define dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180815211054.GA2538@ziepe.ca>
Date:   Wed, 15 Aug 2018 15:10:54 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Joe Perches <joe@...ches.com>
Cc:     Selvin Xavier <selvin.xavier@...adcom.com>,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/bnxt_re: QPLIB: Add and use #define dev_fmt(fmt)
 "QPLIB: " fmt

On Fri, Aug 10, 2018 at 11:42:46AM -0700, Joe Perches wrote:
> Consistently use the "QPLIB: " prefix for dev_<level> logging.
> 
> Miscellanea:
> 
> o Add missing newlines to avoid possible message interleaving
> o Coalesce consecutive dev_<level> uses that emit a message header to
>   avoid < 80 column lengths and mistakenly output on multiple lines
> o Reflow modified lines to use 80 columns where appropriate
> o Consistently use "%s: " where __func__ is output
> o QPLIB: is now always output immediately after the dev_<level> header
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/infiniband/hw/bnxt_re/qplib_fp.c   | 130 +++++++++++------------------
>  drivers/infiniband/hw/bnxt_re/qplib_rcfw.c |  51 ++++++-----
>  drivers/infiniband/hw/bnxt_re/qplib_res.c  |  29 ++++---
>  drivers/infiniband/hw/bnxt_re/qplib_sp.c   |  57 ++++++-------
>  4 files changed, 116 insertions(+), 151 deletions(-)

Broadcom: This is a big patch, will you ack it please?

https://patchwork.kernel.org/patch/10563083/

Thanks,
Jason