linux-kernel - Re: [PATCH] RDMA/bnxt_re: QPLIB: Add and use #define dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+sbYW2bHrV_Tx6rMYj1h9f3i_sJ=7zPMDbrfWWx229CNeQc2g@mail.gmail.com>
Date:   Thu, 16 Aug 2018 16:00:22 +0530
From:   Selvin Xavier <selvin.xavier@...adcom.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Devesh Sharma <devesh.sharma@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RDMA/bnxt_re: QPLIB: Add and use #define dev_fmt(fmt)
 "QPLIB: " fmt

On Sat, Aug 11, 2018 at 12:12 AM Joe Perches <joe@...ches.com> wrote:
>
> Consistently use the "QPLIB: " prefix for dev_<level> logging.
>
> Miscellanea:
>
> o Add missing newlines to avoid possible message interleaving
> o Coalesce consecutive dev_<level> uses that emit a message header to
>   avoid < 80 column lengths and mistakenly output on multiple lines
> o Reflow modified lines to use 80 columns where appropriate
> o Consistently use "%s: " where __func__ is output
> o QPLIB: is now always output immediately after the dev_<level> header
>
> Signed-off-by: Joe Perches <joe@...ches.com>

Thanks for the patch, Joe.

Acked-by: Selvin Xavier <selvin.xavier@...adcom.com>