linux-kernel - Re: [PATCH 2/2] Replace magic for trusting the secondary keyring with #define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Aug 2018 05:14:13 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yannik Sembritzki <yannik@...britzki.me>
Cc:     kbuild-all@...org, Linus Torvalds <torvalds@...ux-foundation.org>,
        David Howells <dhowells@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Peter Anvin <hpa@...or.com>,
        the arch/x86 maintainers <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dave Young <dyoung@...hat.com>, Baoquan He <bhe@...hat.com>,
        "Justin M. Forbes" <jforbes@...hat.com>,
        Peter Jones <pjones@...hat.com>,
        James Bottomley <James.Bottomley@...senPartnership.com>,
        Matthew Garrett <mjg59@...gle.com>,
        Vivek Goyal <vgoyal@...hat.com>,
        Yannik Sembritzki <yannik@...britzki.me>
Subject: Re: [PATCH 2/2] Replace magic for trusting the secondary keyring
 with #define

Hi Yannik,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18 next-20180814]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yannik-Sembritzki/Fix-kexec-forbidding-kernels-signed-with-keys-in-the-secondary-keyring-to-boot/20180816-042529
config: x86_64-randconfig-x019-201832 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/keys/asymmetric-type.h:18:0,
                    from crypto/asymmetric_keys/asymmetric_keys.h:12,
                    from crypto/asymmetric_keys/restrict.c:17:
>> include/linux/verification.h:12:0: error: unterminated #ifndef
    #ifndef _LINUX_VERIFICATION_H
    
--
   In file included from include/crypto/pkcs7.h:15:0,
                    from crypto/asymmetric_keys/pkcs7_parser.h:13,
                    from crypto/asymmetric_keys/pkcs7_parser.c:20:
>> include/linux/verification.h:12:0: error: unterminated #ifndef
    #ifndef _LINUX_VERIFICATION_H
    
   In file included from include/keys/asymmetric-type.h:18:0,
                    from crypto/asymmetric_keys/x509_parser.h:14,
                    from crypto/asymmetric_keys/pkcs7_parser.h:14,
                    from crypto/asymmetric_keys/pkcs7_parser.c:20:
>> include/linux/verification.h:12:0: error: unterminated #ifndef
    #ifndef _LINUX_VERIFICATION_H
    

vim +12 include/linux/verification.h

e68503bd David Howells 2016-04-06 @12  #ifndef _LINUX_VERIFICATION_H
e68503bd David Howells 2016-04-06  13  #define _LINUX_VERIFICATION_H
e68503bd David Howells 2016-04-06  14  

:::::: The code at line 12 was first introduced by commit
:::::: e68503bd6836ba765dc8e0ee77ea675fedc07e41 KEYS: Generalise system_verify_data() to provide access to internal content

:::::: TO: David Howells <dhowells@...hat.com>
:::::: CC: David Howells <dhowells@...hat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29822 bytes)