linux-kernel - [PATCH] Input: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Aug 2018 14:46:02 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     Roy Im <roy.im.opensource@...semi.com>
Cc:     kbuild-all@...org, Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Support Opensource <support.opensource@...semi.com>,
        devicetree@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] Input: fix boolreturn.cocci warnings

From: kbuild test robot <fengguang.wu@...el.com>

drivers/input/misc/da7280.c:116:9-10: WARNING: return of 0/1 in function 'da7280_volatile_register' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: a067f5d53e35 ("Input: new da7280 haptic driver")
CC: Roy Im <roy.im.opensource@...semi.com>
Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
---

 da7280.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/input/misc/da7280.c
+++ b/drivers/input/misc/da7280.c
@@ -113,9 +113,9 @@ static bool da7280_volatile_register(str
 	case DA7280_IRQ_EVENT_SEQ_DIAG:
 	case DA7280_IRQ_STATUS1:
 	case DA7280_TOP_CTL1:
-		return 1;
+		return true;
 	default:
-		return 0;
+		return false;
 	}
 }