linux-kernel - [PATCH] Input: fix irqf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180816064602.GA95363@cairo>
Date:   Thu, 16 Aug 2018 14:46:02 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     Roy Im <roy.im.opensource@...semi.com>
Cc:     kbuild-all@...org, Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Support Opensource <support.opensource@...semi.com>,
        devicetree@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] Input: fix irqf_oneshot.cocci warnings

From: kbuild test robot <fengguang.wu@...el.com>

drivers/input/misc/da7280.c:1335:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
 threaded IRQs without a primary handler need to be requested with
 IRQF_ONESHOT, otherwise the request will fail.

 So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Fixes: a067f5d53e35 ("Input: new da7280 haptic driver")
CC: Roy Im <roy.im.opensource@...semi.com>
Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
---

Please take the patch only if it's a positive warning. Thanks!

 da7280.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/input/misc/da7280.c
+++ b/drivers/input/misc/da7280.c
@@ -1334,7 +1334,7 @@ static int da7280_probe(struct i2c_clien
 
 	ret = devm_request_threaded_irq(dev, client->irq, NULL,
 					da7280_irq_handler,
-					DA7280_IRQ_FLAGS,
+					DA7280_IRQ_FLAGS | IRQF_ONESHOT,
 					"da7280-haptics", haptics);
 	if (ret != 0) {
 		dev_err(dev,