linux-kernel - Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Aug 2018 23:23:50 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sedat Dilek <sedat.dilek@...dativ.de>
Cc:     kbuild-all@...org, Wolfram Sang <wsa@...-dreams.de>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Sedat Dilek <sedat.dilek@...dativ.de>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler
 warning

Hi Sedat,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on v4.18 next-20180817]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sedat-Dilek/i2c-Remove-Wno-deprecated-declarations-compiler-warning/20180819-215230
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: i386-randconfig-a0-201833 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers//i2c/i2c-core-base.c: In function 'i2c_do_add_adapter':
>> drivers//i2c/i2c-core-base.c:1128:2: warning: 'attach_adapter' is deprecated (declared at include/linux/i2c.h:274) [-Wdeprecated-declarations]
     if (driver->attach_adapter) {
     ^
   drivers//i2c/i2c-core-base.c:1134:3: warning: 'attach_adapter' is deprecated (declared at include/linux/i2c.h:274) [-Wdeprecated-declarations]
      driver->attach_adapter(adap);
      ^

vim +/attach_adapter +1128 drivers//i2c/i2c-core-base.c

9c1600ed drivers/i2c/i2c-core.c David Brownell  2007-05-01  1120  
69b0089a drivers/i2c/i2c-core.c Jean Delvare    2009-12-06  1121  static int i2c_do_add_adapter(struct i2c_driver *driver,
69b0089a drivers/i2c/i2c-core.c Jean Delvare    2009-12-06  1122  			      struct i2c_adapter *adap)
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1123  {
4735c98f drivers/i2c/i2c-core.c Jean Delvare    2008-07-14  1124  	/* Detect supported devices on that bus, and instantiate them */
4735c98f drivers/i2c/i2c-core.c Jean Delvare    2008-07-14  1125  	i2c_detect(adap, driver);
4735c98f drivers/i2c/i2c-core.c Jean Delvare    2008-07-14  1126  
4735c98f drivers/i2c/i2c-core.c Jean Delvare    2008-07-14  1127  	/* Let legacy drivers scan this bus for matching devices */
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27 @1128  	if (driver->attach_adapter) {
a920ff41 drivers/i2c/i2c-core.c Jean Delvare    2011-04-17  1129  		dev_warn(&adap->dev, "%s: attach_adapter method is deprecated\n",
a920ff41 drivers/i2c/i2c-core.c Jean Delvare    2011-04-17  1130  			 driver->driver.name);
b93d3d37 drivers/i2c/i2c-core.c Andy Shevchenko 2016-08-25  1131  		dev_warn(&adap->dev,
b93d3d37 drivers/i2c/i2c-core.c Andy Shevchenko 2016-08-25  1132  			 "Please use another way to instantiate your i2c_client\n");
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1133  		/* We ignore the return code; if it fails, too bad */
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1134  		driver->attach_adapter(adap);
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1135  	}
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1136  	return 0;
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1137  }
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1138  

:::::: The code at line 1128 was first introduced by commit
:::::: 026526f5afcd421dce110f53e4c4e2b9e78753c2 i2c: Drop redundant i2c_driver.list

:::::: TO: Jean Delvare <khali@...ux-fr.org>
:::::: CC: Jean Delvare <khali@...erion.delvare>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27137 bytes)