linux-kernel - Re: [PATCH v4 1/3] i2c: imx: Fix race condition in dma read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180820091338.x2nofnytf7z27omk@ninjato>
Date:   Mon, 20 Aug 2018 11:13:38 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Esben Haabendal <esben.haabendal@...il.com>
Cc:     linux-i2c@...r.kernel.org, Esben Haabendal <eha@...f.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lucas Stach <l.stach@...gutronix.de>,
        Phil Reid <preid@...ctromag.com.au>,
        Fabio Estevam <fabio.estevam@....com>,
        Peter Rosin <peda@...ntia.se>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] i2c: imx: Fix race condition in dma read

On Thu, Aug 16, 2018 at 10:43:12AM +0200, Esben Haabendal wrote:
> From: Esben Haabendal <eha@...f.com>
> 
> This fixes a race condition, where the DMAEN bit ends up being set after
> I2C slave has transmitted a byte following the dummy read.  When that
> happens, an interrupt is generated instead, and no DMA request is generated
> to kickstart the DMA read, and a timeout happens after DMA_TIMEOUT (1 sec).
> 
> Fixed by setting the DMAEN bit before the dummy read.
> 
> Signed-off-by: Esben Haabendal <eha@...f.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Applied to for-next and added stable, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)