linux-kernel - Re: [PATCH v4 2/3] i2c: imx: Simplify stopped state tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874lfpiec3.fsf@gmail.com>
Date:   Mon, 20 Aug 2018 11:20:44 +0200
From:   Esben Haabendal <esben.haabendal@...il.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     linux-i2c@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lucas Stach <l.stach@...gutronix.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Phil Reid <preid@...ctromag.com.au>,
        Peter Rosin <peda@...ntia.se>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] i2c: imx: Simplify stopped state tracking

Wolfram Sang <wsa@...-dreams.de> writes:

> On Thu, Aug 16, 2018 at 10:43:13AM +0200, Esben Haabendal wrote:
>> From: Esben Haabendal <eha@...f.com>
>> 
>> Always update the stopped state when busy status have been checked.
>> This is identical to what was done before, with the exception of error
>> handling.
>> Without this change, some errors cause the stopped state to be left in
>> incorrect state in i2c_imx_stop(), i2c_imx_dma_read(), i2c_imx_read() and
>> i2c_imx_xfer().
>> 
>> Signed-off-by: Esben Haabendal <eha@...f.com>
>> Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> Applied to for-next, thanks! I did not add stable because the cover
> latter said minor issue? Not really sure here, though...

I agree, it does not need to go into stable.

/Esben