linux-kernel - Query on skip_onerr field in struct cpuhp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <c228c495-63fa-5af9-32ff-355410d78cc8@codeaurora.org>
Date:   Tue, 21 Aug 2018 19:17:31 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     lkml <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Query on skip_onerr field in struct cpuhp_step

Hi All,

This is about one of field in struct cpuhp_step

* @skip_onerr: Do not invoke the functions on error rollback
  *              Will go away once the notifiers are gone
         bool                    skip_onerr;

Why this field was introduced, can anyone explain the history behind ? 
As i don't see it being set from anywhere

If it is specifically was dependent on notifiers, did we missed to 
remove it as the notifiers are gone or the usecase still there?
And If it is still valid, in what scenario i would not want my callback 
to be called in rollback path?

Thanks,
Mukesh