linux-kernel - Re: Query on skip_onerr field in struct cpuhp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Aug 2018 20:10:47 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     lkml <linux-kernel@...r.kernel.org>
Subject: Re: Query on skip_onerr field in struct cpuhp_step



On 8/21/2018 7:27 PM, Thomas Gleixner wrote:
> On Tue, 21 Aug 2018, Mukesh Ojha wrote:
>> Hi All,
>>
>> This is about one of field in struct cpuhp_step
>>
>> * @skip_onerr: Do not invoke the functions on error rollback
>>   *              Will go away once the notifiers are gone
>>          bool                    skip_onerr;
>>
>> Why this field was introduced, can anyone explain the history behind ? As i
>> don't see it being set from anywhere
>>
>> If it is specifically was dependent on notifiers, did we missed to remove it
>> as the notifiers are gone or the usecase still there?
> As the comment says....

Thanks for your reply
Sorry, for further question but i did not get the comment ..did you 
mean, we can remove this from the structure as notifier are
not their now. ?

Also if you are aware with the history, can you tell , why would i want 
to avoid a call in undo_cpu_up path?

Thanks,
Mukesh