linux-kernel - Re: [PATCH] percpu: cleanup PER_CPU_DEF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180821155611.GN3978217@devbig004.ftw2.facebook.com>
Date:   Tue, 21 Aug 2018 08:56:11 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Alexander Pateenok <pateenoc@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Christoph Lameter <cl@...ux.com>,
        Dennis Zhou <dennisszhou@...il.com>,
        linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] percpu: cleanup PER_CPU_DEF_ATTRIBUTES macro

Hello,

On Tue, Aug 21, 2018 at 04:40:30PM +0300, Alexander Pateenok wrote:
> The macro is not used:
> 
>   $ grep -r PER_CPU_DEF_ATTRIBUTES
>   include/linux/percpu-defs.h:	__PCPU_ATTRS(sec) PER_CPU_DEF_ATTRIBUTES __weak		\
>   include/linux/percpu-defs.h:	__PCPU_ATTRS(sec) PER_CPU_DEF_ATTRIBUTES		\
>   include/asm-generic/percpu.h:#ifndef PER_CPU_DEF_ATTRIBUTES
>   include/asm-generic/percpu.h:#define PER_CPU_DEF_ATTRIBUTES
> 
> It was added with b01e8dc34379 ("alpha: fix percpu build breakage") and
> removed in 2009 with b01e8dc34379..6088464cf1ae.
> 
> Signed-off-by: Alexander Pateenok <pateenoc@...il.com>

I'm not sure this is a meaningful cleanup, but then again, why not?
Can you please repost the patch to Andrew so that it can go through
-mm tree?  Please feel free to add

 Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun