linux-kernel - Re: [PATCH 0/4] numa, iommu/smmu: IOMMU/SMMU driver optimization for NUMA systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7fc1e43-3652-562a-1e59-499be80b567c@arm.com>
Date:   Wed, 22 Aug 2018 15:56:43 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     John Garry <john.garry@...wei.com>,
        Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "Will.Deacon@....com" <Will.Deacon@....com>,
        "gklkml16@...il.com" <gklkml16@...il.com>,
        "Tomasz.Nowicki@...ium.com" <Tomasz.Nowicki@...ium.com>,
        "Robert.Richter@...ium.com" <Robert.Richter@...ium.com>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "jnair@...iumnetworks.com" <jnair@...iumnetworks.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        "thunder.leizhen@...wei.com" <thunder.leizhen@...wei.com>,
        Linuxarm <linuxarm@...wei.com>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 0/4] numa, iommu/smmu: IOMMU/SMMU driver optimization for
 NUMA systems

Hi John,

On 22/08/18 14:44, John Garry wrote:
> On 21/09/2017 09:59, Ganapatrao Kulkarni wrote:
>> Adding numa aware memory allocations used for iommu dma allocation and
>> memory allocated for SMMU stream tables, page walk tables and command 
>> queues.
>>
>> With this patch, iperf testing on ThunderX2, with 40G NIC card on
>> NODE 1 PCI shown same performance(around 30% improvement) as NODE 0.
>>
>> Ganapatrao Kulkarni (4):
>>   mm: move function alloc_pages_exact_nid out of __meminit
>>   numa, iommu/io-pgtable-arm: Use NUMA aware memory allocation for smmu
>>     translation tables
>>   iommu/arm-smmu-v3: Use NUMA memory allocations for stream tables and
>>     comamnd queues
>>   iommu/dma, numa: Use NUMA aware memory allocations in
>>     __iommu_dma_alloc_pages
>>
>>  drivers/iommu/arm-smmu-v3.c    | 57 
>> +++++++++++++++++++++++++++++++++++++-----
>>  drivers/iommu/dma-iommu.c      | 17 +++++++------
>>  drivers/iommu/io-pgtable-arm.c |  4 ++-
>>  include/linux/gfp.h            |  2 +-
>>  mm/page_alloc.c                |  3 ++-
>>  5 files changed, 67 insertions(+), 16 deletions(-)
>>
> 
> Hi Ganapatrao,
> 
> Have you any plans for further work on this patchset? I have not seen 
> anything since this v1 was posted+discussed.

Looks like I ended up doing the version of the io-pgtable change that I 
suggested here, which was merged recently (4b123757eeaa). Patch #3 
should also be effectively obsolete now since the SWIOTLB/dma-direct 
rework (21f237e4d085). Apparently I also started reworking patch #4 in 
my tree at some point but sidelined it - I think that was at least 
partly due to another thread[1] which made it seem less clear-cut 
whether this is always the right thing to do.

Robin.

[1] 
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1693026.html