linux-kernel - Re: [PATCH 4/9] mmc: meson-mx-sdio: fix OF child-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCAKNUA5_fz4bXqj-aCaDEHk--Ax5GXJt+nzVKSjbVHxLg@mail.gmail.com>
Date:   Thu, 23 Aug 2018 20:50:23 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     johan@...nel.org
Cc:     robh+dt@...nel.org, gregkh@...uxfoundation.org,
        frowand.list@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        carlo@...lessm.com, ulf.hansson@...aro.org
Subject: Re: [PATCH 4/9] mmc: meson-mx-sdio: fix OF child-node lookup

Hi Johan,

On Wed, Aug 22, 2018 at 12:57 PM Johan Hovold <johan@...nel.org> wrote:
>
> Use the new of_get_compatible_child() helper to lookup the slot child
> node instead of using of_find_compatible_node(), which searches the
> entire tree and thus can return an unrelated (i.e. non-child) node.
that new helper is much appreciated, thank you!

> This also addresses a potential use-after-free (e.g. after probe
> deferral) as the tree-wide helper drops a reference to its first
> argument (i.e. the node of the device being probed).
>
> While at it, also fix up the related slot-node reference leak.
not sure why both issues went unnoticed so far - good that they're now
both fixed. thank you!

> Fixes: ed80a13bb4c4 ("mmc: meson-mx-sdio: Add a driver for the Amlogic Meson8 and Meson8b SoCs")
> Cc: stable <stable@...r.kernel.org>     # 4.15
backporting only works if the patch introducing
of_get_compatible_child is also backported
do we have to inform Greg somehow?

> Cc: Carlo Caione <carlo@...lessm.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Signed-off-by: Johan Hovold <johan@...nel.org>
Acked-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>


Regards
Martin