linux-kernel - Re: [PATCH 9/9] power: supply: twl4030-charger: fix OF sibling-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180823074035.GQ14967@localhost>
Date:   Thu, 23 Aug 2018 09:40:35 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Johan Hovold <johan@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable <stable@...r.kernel.org>, NeilBrown <neilb@...e.de>,
        Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 9/9] power: supply: twl4030-charger: fix OF sibling-node
 lookup

On Wed, Aug 22, 2018 at 11:36:58PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Wed, Aug 22, 2018 at 12:55:47PM +0200, Johan Hovold wrote:
> > Use the new of_get_compatible_child() helper to lookup the usb sibling
> > node instead of using of_find_compatible_node(), which searches the
> > entire tree and thus can return an unrelated (non-sibling) node.
> > 
> > This also addresses a potential use-after-free (e.g. after probe
> > deferral) as the tree-wide helper drops a reference to its first
> > argument (i.e. the parent device node).
> > 
> > While at it, also fix the related phy-node reference leak.
> > 
> > Fixes: f5e4edb8c888 ("power: twl4030_charger: find associated phy by more reliable means.")
> > Cc: stable <stable@...r.kernel.org>     # 4.2
> > Cc: NeilBrown <neilb@...e.de>
> > Cc: Felipe Balbi <balbi@...com>
> > Cc: Sebastian Reichel <sre@...nel.org>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---
> 
> Reviewed-by: Sebastian Reichel <sre@...nel.org>

Thanks for reviewing.

Johan