linux-kernel - Re: [PATCH 1/2] media: ipu3-cio2: Use dma_zalloc_coherent to replace dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B7F7D49.10206@huawei.com>
Date:   Fri, 24 Aug 2018 11:36:41 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     Bing Bu Cao <bingbu.cao@...ux.intel.com>
CC:     <yong.zhi@...el.com>, <sakari.ailus@...ux.intel.com>,
        <bingbu.cao@...el.com>, <mchehab@...nel.org>,
        <matthias.bgg@...il.com>, <tian.shu.qiu@...el.com>,
        <jian.xu.zheng@...el.com>, <linux-kernel@...r.kernel.org>,
        <linux-media@...r.kernel.org>
Subject: Re: [PATCH 1/2] media: ipu3-cio2: Use dma_zalloc_coherent to replace
 dma_alloc_coherent + memset

On 2018/8/24 10:58, Bing Bu Cao wrote:
> Hi, Jiang
>
> This looks fine for me in ipu3-cio2.
> Actually, we already have this change locally, but I think we miss submit it to community.
> Thanks!
 It's ok,  Anyway,  Thank you for let me know that.

 Best wishes,
 zhong jiang
> On 08/18/2018 11:16 PM, zhong jiang wrote:
>> dma_zalloc_coherent has implemented the dma_alloc_coherent() + memset(),
>> We prefer to dma_zalloc_coherent instead of open-codeing.
>>
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
>> ---
>>  drivers/media/pci/intel/ipu3/ipu3-cio2.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
>> index 2902715..f0c6374 100644
>> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
>> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
>> @@ -218,13 +218,11 @@ static int cio2_fbpt_init(struct cio2_device *cio2, struct cio2_queue *q)
>>  {
>>  	struct device *dev = &cio2->pci_dev->dev;
>>  
>> -	q->fbpt = dma_alloc_coherent(dev, CIO2_FBPT_SIZE, &q->fbpt_bus_addr,
>> -				     GFP_KERNEL);
>> +	q->fbpt = dma_zalloc_coherent(dev, CIO2_FBPT_SIZE, &q->fbpt_bus_addr,
>> +				      GFP_KERNEL);
>>  	if (!q->fbpt)
>>  		return -ENOMEM;
>>  
>> -	memset(q->fbpt, 0, CIO2_FBPT_SIZE);
>> -
>>  	return 0;
>>  }
>>  
>
> .
>