linux-kernel - Re: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180824034119.GA29111@lunn.ch>
Date:   Fri, 24 Aug 2018 05:41:19 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Peng Li <lipeng321@...wei.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com
Subject: Re: [PATCH NET 3/3] net: hns: add configuration constraints for
 1000M half

On Fri, Aug 24, 2018 at 11:42:23AM +0800, Peng Li wrote:
> Hisilicon hip05 and hip06 board network card do not support
> 1000M half configuration. Driver can not config gmac as
> 1000M half.
> 
> Signed-off-by: Peng Li <lipeng321@...wei.com>

Hi Peng

Does the driver remove SUPPORTED_1000baseT_Half from
phydev->supported?  If you do that, the PHY should never negotiate
this speed.

   Andrew