linux-kernel - Re: [PATCH] staging: comedi: drivers: adl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 25 Aug 2018 10:14:50 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Sven Luthi <dev@...nluthi.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        abbotti@....co.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: adl_pci9118: Fixes format of
 line 1283.

On Fri, Aug 24, 2018 at 11:06:56PM +0200, Sven Luthi wrote:
> Checkpatch repored "Lines should not end with a '('" for line 1283.
> 
> Moved opening parenthesis of function on line 1283 onto next line.
> 
> Signed-off-by: Sven Luthi <dev@...nluthi.com>
> ---
>  drivers/staging/comedi/drivers/adl_pci9118.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 2528ca0ede6d..07431dc9cde9 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -1280,8 +1280,8 @@ static int pci9118_ai_cmdtest(struct comedi_device *dev,
>  			} else {
>  				arg = cmd->convert_arg * cmd->chanlist_len;
>  			}
> -			err |= comedi_check_trigger_arg_min(
> -				&cmd->scan_begin_arg, arg);
> +			err |= comedi_check_trigger_arg_min
> +			       (&cmd->scan_begin_arg, arg);

The original is fine.  It's probably better than the new version.
Checkpatch.pl is just a hint, not a command.

regards,
dan carpenter