linux-kernel - Re: [PATCH] staging: comedi: cb_pcidas64 fixed '(' coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180825071535.igoxbyleusti6wyu@mwanda>
Date:   Sat, 25 Aug 2018 10:15:35 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     GuyLuz <guyluz50@...il.com>
Cc:     devel@...verdev.osuosl.org, guyluz11@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: cb_pcidas64 fixed '('  coding style
 issue

On Sat, Aug 25, 2018 at 02:07:01AM +0300, GuyLuz wrote:
> From: Guy Luz <guyluz50@...il.com>
> 
> Fixed a  Lines should not end with a '(' issue.
> 
> Signed-off-by: Guy Luz <guyluz50@...il.com>
> ---
>  drivers/staging/comedi/drivers/cb_pcidas64.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index 63992c0babf7..a85334f53ff9 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2173,10 +2173,9 @@ static int ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
>  			 * allows
>  			 */
>  			if (cmd->scan_begin_src == TRIG_TIMER) {
> -				err |= comedi_check_trigger_arg_min(
> -						&cmd->scan_begin_arg,
> -						cmd->convert_arg *
> -						cmd->chanlist_len);
> +				err |= comedi_check_trigger_arg_min
> +				(&cmd->scan_begin_arg, cmd->convert_arg *
> +				cmd->chanlist_len);

The original is better than the new version.  Please leave it as is.

regards,
dan carpenter