linux-kernel - Re: [PATCH V5 4/8] backlight: qcom-wled: Rename PM8941* to WLED3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180827150429.GM3048@tuxbook-pro>
Date:   Mon, 27 Aug 2018 08:04:29 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Kiran Gunda <kgunda@...eaurora.org>, jingoohan1@...il.com,
        lee.jones@...aro.org, b.zolnierkie@...sung.com,
        dri-devel@...ts.freedesktop.org, daniel.thompson@...aro.org,
        jacek.anaszewski@...il.com, robh+dt@...nel.org,
        mark.rutland@....com, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fbdev@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH V5 4/8] backlight: qcom-wled: Rename PM8941* to WLED3

On Mon 27 Aug 03:04 PDT 2018, Pavel Machek wrote:

> On Fri 2018-08-24 15:57:43, Kiran Gunda wrote:
> > Rename the PM8941* references as WLED3 to make the driver
> > generic and have WLED support for other PMICs. Also rename
> > "i_boost_limit" and "i_limit" variables to "boost_i_limit"
> > and "string_i_limit" respectively to resemble the corresponding
> > register names.
> 
> Acked-by: Pavel Machek <pavel@....cz>
> 
> > -MODULE_DESCRIPTION("pm8941 wled driver");
> > +MODULE_DESCRIPTION("Qualcomm WLED driver");
> 
> "... supporting pm8941, xxx devices" ?
> 

I would suggest not doing this. There's quite a long list of different
PMICs containing some version of this hardware block.

Regards,
Bjorn