linux-kernel - Re:Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3571f5ca.c32c.1657be858d1.Coremail.liuxiang_1999@126.com>
Date:   Mon, 27 Aug 2018 23:02:29 +0800 (CST)
From:   liuxiang <liuxiang_1999@....com>
To:     "Boris Brezillon" <boris.brezillon@...tlin.com>
Cc:     "Liu Xiang" <liu.xiang6@....com.cn>, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, han.xu@....com,
        marek.vasut@...il.com, dwmw2@...radead.org,
        computersforpeace@...il.com, richard@....at,
        "Yogesh Narayan Gaur" <yogeshnarayan.gaur@....com>
Subject: Re:Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash
 size larger than 16MB



Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale QuadSPI driver")
Cc: stable@...r.kernel.org

Should I send a V2 patch that adds these above？




At 2018-08-27 16:06:13, "Boris Brezillon" <boris.brezillon@...tlin.com> wrote:
>On Sat, 18 Aug 2018 17:14:23 +0800
>Liu Xiang <liu.xiang6@....com.cn> wrote:
>
>> If the size of spi-nor flash is larger than 16MB, the read_opcode
>> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
>> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
>> cause read operation fail.
>> 
>> Signed-off-by: Liu Xiang <liu.xiang6@....com.cn>
>
>I'm pretty sure you want to backport this fix. Can you add a Fixes tag
>and CC stable?
>
>Also, I'd like to have an Ack from someone working at NXP (Han,
>Yogesh?).
>
>Thanks,
>
>Boris.
>
>> ---
>>  drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
>> index 7d9620c..64304a3 100644
>> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
>> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
>> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>>  {
>>  	switch (cmd) {
>>  	case SPINOR_OP_READ_1_1_4:
>> +	case SPINOR_OP_READ_1_1_4_4B:
>>  		return SEQID_READ;
>>  	case SPINOR_OP_WREN:
>>  		return SEQID_WREN;