lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Aug 2018 18:31:09 +0200 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: zhong jiang <zhongjiang@...wei.com> Cc: rui.zhang@...el.com, edubezval@...il.com, jonathanh@...dia.com, linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, ezequiel@...labora.com Subject: Re: [PATCH v2] drivers/thermal/tegra: Fix a double free on the device node On 27/08/2018 15:32, zhong jiang wrote: > The function 'for_each_child_of_node' iterates over the node list by > dropping the of_node reference of the previous node. > > Calling of_node_put() on the iterator is pointless and leads to an > inconsistent refcounting in addition to a double free. Remove it. > > Acked-by: Jon Hunter <jonathanh@...dia.com> > Signed-off-by: zhong jiang <zhongjiang@...wei.com> Reviewed-by: Daniel Lezcano <daniel.lezcano@...aro.org> > --- > v1->v2: According to Daniel's suggestion. I modify the subject and commit log. > > drivers/thermal/tegra/soctherm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c > index ed28110..3aa55c9 100644 > --- a/drivers/thermal/tegra/soctherm.c > +++ b/drivers/thermal/tegra/soctherm.c > @@ -980,7 +980,6 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev) > tcd = thermal_of_cooling_device_register(np_stcc, > (char *)name, ts, > &throt_cooling_ops); > - of_node_put(np_stcc); > if (IS_ERR_OR_NULL(tcd)) { > dev_err(dev, > "throttle-cfg: %s: failed to register cooling device\n", > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists