linux-kernel - Re: [PATCH v2] drivers/thermal/tegra: Fix a double free on the device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180926152459.GL12980@ulmo>
Date:   Wed, 26 Sep 2018 17:24:59 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     daniel.lezcano@...aro.org, rui.zhang@...el.com,
        edubezval@...il.com, jonathanh@...dia.com,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        ezequiel@...labora.com
Subject: Re: [PATCH v2] drivers/thermal/tegra: Fix a double free on the
 device node

On Mon, Aug 27, 2018 at 09:32:18PM +0800, zhong jiang wrote:
> The function 'for_each_child_of_node' iterates over the node list by
> dropping the of_node reference of the previous node.
> 
> Calling of_node_put() on the iterator is pointless and leads to an
> inconsistent refcounting in addition to a double free. Remove it.
> 
> Acked-by: Jon Hunter <jonathanh@...dia.com>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
> v1->v2: According to Daniel's suggestion. I modify the subject and commit log.
> 
>  drivers/thermal/tegra/soctherm.c | 1 -
>  1 file changed, 1 deletion(-)

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)