linux-kernel - Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <702eb090-2bf4-69d1-bfb6-afdca4ba5c5f@kernel.dk>
Date:   Tue, 28 Aug 2018 11:12:12 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Ian W MORRISON <ianwmorrison@...il.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        kashyap.desai@...adcom.com, loberman@...hat.com, osandov@...com,
        hch@....de, bart.vanassche@....com, hare@...e.de,
        ming.lei@...hat.com, Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in
 case of 'none'"

On 8/28/18 11:01 AM, Ian W MORRISON wrote:
> On Wed, 29 Aug 2018 at 02:13, Jens Axboe <axboe@...nel.dk> wrote:
>>
>> On 8/28/18 10:10 AM, Ian W MORRISON wrote:
>>> On Wed, 29 Aug 2018 at 02:09, Jens Axboe <axboe@...nel.dk> wrote:
>>>>
>>>> On 8/28/18 10:07 AM, Ian W MORRISON wrote:
>>>>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@...nel.dk> wrote:
>>>>>>
>>>>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote:
>>>>>>> Kernel oops when booting on Bay and Cherry Trail devices
>>>>>>> such as Intel Compute Stick. Bisected as:
>>>>>>>
>>>>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'")
>>>>>>>
>>>>>>> This patch reverts the above commit.
>>>>>>
>>>>>> Did I miss the posting of that oops? Just curious where this is
>>>>>> going wrong. Not adverse to reverting, but I'd like to try to
>>>>>> understand the issue first.
>>>>>>
>>>>>> --
>>>>>> Jens Axboe
>>>>>>
>>>>>
>>>>> I've not been able to capture it however manually transcribing what is
>>>>> on the screen:
>>>>>
>>>>> mmc0: Got data interrupt 0x00000002 even though no data operation
>>>>>
>>>>> followed by:
>>>>>
>>>>> mmc0: sdhci: ============= SDHCI REGISTER DUMP ==============
>>>>>
>>>>> Do you want any specific register value or should I transcribe each
>>>>> (as I am working from an image taken at boot)?
>>>>
>>>> Just take a picture of the screen, that should be good enough.
>>>>
>>>> --
>>>> Jens Axboe
>>>>
>>>
>>> Attached as requested.
>>
>> Can you see if this patch helps?
>>
>> https://marc.info/?l=linux-mmc&m=153485326025301&w=2
>>
>> --
>> Jens Axboe
>>
> 
> I confirm that the above patch works with commit 6ce3dd6eec11
> and removes the need for reverting it on eMMC based devices.
> 
> Tested on Bay Trail, Cherry Trail (both now working) and Kaby Lake
> (not affected) devices.

Great, thanks for testing. Adrian, when is this going upstream?

-- 
Jens Axboe