linux-kernel - Re: [PATCH 2/2] scsi: aic7xxx: Fix build using bare-metal toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKaJLVsPYG8CvOj1NjBuH4GrfobfXvsLeQE6kFEiyRkSZ_Omaw@mail.gmail.com>
Date:   Wed, 29 Aug 2018 17:01:00 +0300
From:   Sam Protsenko <semen.protsenko@...aro.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        codalist@...a.cs.cmu.edu, coda@...cmu.edu,
        Jan Harkes <jaharkes@...cmu.edu>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Praneeth Bajjuri <praneeth@...com>,
        Paul Sokolovsky <paul.sokolovsky@...aro.org>,
        Miklos Szeredi <mszeredi@...e.cz>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Ruslan Bilovol <ruslan.bilovol@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH 2/2] scsi: aic7xxx: Fix build using bare-metal toolchain

On Wed, Aug 29, 2018 at 9:32 AM, Christoph Hellwig <hch@...radead.org> wrote:
> On Tue, Aug 28, 2018 at 05:24:21PM +0300, Sam Protsenko wrote:
>> Bare-metal toolchains don't define __linux__, so aic7xxx build with
>> bare-metal toolchain is broken. Let's check __KERNEL__ definition
>> instead of __linux__ (as this code won't be build for user-space anyway)
>> in order to fix that.
>
> Please just drop the ifdefs entirely.  The codebase used to be partially
> shared with at least FreeBSD, but these days there is no point in
> keeping the compatibility around.

Thanks, Christoph. Will do in v2.