linux-kernel - Re: [PATCH 1/2] codafs: Fix build using bare-metal toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKaJLVvhGGoVnWxaDGN60ySiZ_y4xOUkamNQRnad3V7SNsNL-A@mail.gmail.com>
Date:   Wed, 29 Aug 2018 17:03:44 +0300
From:   Sam Protsenko <semen.protsenko@...aro.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        codalist@...a.cs.cmu.edu, coda@...cmu.edu,
        Jan Harkes <jaharkes@...cmu.edu>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Praneeth Bajjuri <praneeth@...com>,
        Paul Sokolovsky <paul.sokolovsky@...aro.org>,
        Miklos Szeredi <mszeredi@...e.cz>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Ruslan Bilovol <ruslan.bilovol@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH 1/2] codafs: Fix build using bare-metal toolchain

On Wed, Aug 29, 2018 at 9:33 AM, Christoph Hellwig <hch@...radead.org> wrote:
> Please just drop the ifdef entirely.  The file is part of the kernel
> tree and can't be used for anything non-Linux.

I have better idea :) We can modify include/linux/coda.h instead, by
checking for __KERNEL__ (along with existing check for __linux__).
This way we can leave user-space API header alone. Don't know how come
I didn't notice that in the first place... Anyway, will send v2
shortly. Thanks for the review.