linux-kernel - [PATCH] ACPI / bus: Only call dmi_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180829190614.5814817b@endymion>
Date:   Wed, 29 Aug 2018 19:06:14 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Takashi Iwai <tiwai@...e.de>, "Zheng, Lv" <lv.zheng@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>
Subject: [PATCH] ACPI / bus: Only call dmi_check_system on X86

Calling dmi_check_system() early only works on X86. Other
architectures initialize the DMI subsystem later so it's not
ready yet when ACPI itself gets initialized.

In the best case it results in a useless call to a function which
will do nothing. But depending on the dmi implementation, it could
also result in warnings. Best is to not call the function when it
can't work and isn't needed.

Additionally, if anyone ever needs to add non-x86 quirks, it would
surprisingly not work, so document the limitation to avoid confusion.

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Fixes: cce4f632db20 ("ACPI: fix early DSDT dmi check warnings on ia64")
Cc: stable@...r.kernel.org
Cc: Takashi Iwai <tiwai@...e.de>
Cc: "Zheng, Lv" <lv.zheng@...el.com>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net> (supporter:ACPI)
Cc: Len Brown <lenb@...nel.org> (supporter:ACPI)
---
 drivers/acpi/bus.c |   15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

--- linux-4.17.orig/drivers/acpi/bus.c	2018-06-03 23:15:21.000000000 +0200
+++ linux-4.17/drivers/acpi/bus.c	2018-08-29 17:54:09.498532435 +0200
@@ -35,11 +35,11 @@
 #include <linux/delay.h>
 #ifdef CONFIG_X86
 #include <asm/mpspec.h>
+#include <linux/dmi.h>
 #endif
 #include <linux/acpi_iort.h>
 #include <linux/pci.h>
 #include <acpi/apei.h>
-#include <linux/dmi.h>
 #include <linux/suspend.h>
 
 #include "internal.h"
@@ -109,10 +109,6 @@ static const struct dmi_system_id acpi_q
 	},
 	{}
 };
-#else
-static const struct dmi_system_id acpi_quirks_dmi_table[] __initconst = {
-	{}
-};
 #endif
 
 /* --------------------------------------------------------------------------
@@ -1060,8 +1056,15 @@ void __init acpi_early_init(void)
 
 	acpi_permanent_mmap = true;
 
-	/* Check machine-specific quirks */
+#ifdef CONFIG_X86
+	/*
+	 * Check machine-specific quirks
+	 * Note that calling dmi_check_system here on other architectures
+	 * would not be OK because only x86 intializes dmi early enough.
+	 * Thankfully only x86 systems need such quirks for now.
+	 */
 	dmi_check_system(acpi_quirks_dmi_table);
+#endif
 
 	status = acpi_reallocate_root_table();
 	if (ACPI_FAILURE(status)) {


-- 
Jean Delvare
SUSE L3 Support