linux-kernel - Re: [PATCH] locking/lockdep: Delete unnecesary #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b66f7e94b2f2a8c6ac86c26dc6951cde943367fb.camel@decadent.org.uk>
Date:   Wed, 29 Aug 2018 19:30:10 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Will Deacon <will.deacon@....com>,
        linux-kernel@...r.kernel.org,
        Joel Fernandes <joel@...lfernandes.org>,
        Sasha Levin <Alexander.Levin@...rosoft.com>
Subject: Re: [PATCH] locking/lockdep: Delete unnecesary #include

On Wed, 2018-08-29 at 09:49 -0400, Steven Rostedt wrote:
> On Wed, 29 Aug 2018 11:31:21 +0200
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Tue, Aug 28, 2018 at 09:33:15PM +0100, Ben Hutchings wrote:
> > > Commit c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints and u
> > > nify their usage") added the inclusion of <trace/events/preemptirq.h>.
> > > liblockdep doesn't have a stub version of that header so now fails to
> > > build.
> > > 
> > > However, commit bff1b208a5d1 ("tracing: Partial revert of "tracing:
> > > Centralize preemptirq tracepoints and unify their usage"") removed the
> > > use of functions declared in that header.  So delete the #include.
> > > 
> > > Fixes: c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints ...")
> > > Fixes: bff1b208a5d1 ("tracing: Partial revert of "tracing: Centralize ...")  
> > 
> > There's no actual breakage because of this extra include, is there?
> 
> I believe the user tool in tools/lib/lockdep fails because of it.
> Although, I just tried building it myself, and it fails because of
> nmi.h header file.

Sasha already sent fixes to fix that and another missing definition,
but they haven't been applied.

Ben.

-- 
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)