linux-kernel - Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b621a12258c3f0d0a9fcb61ac454af4822814e67.camel@perches.com>
Date:   Wed, 29 Aug 2018 14:14:01 -0700
From:   Joe Perches <joe@...ches.com>
To:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org,
        "Larry.Finger" <Larry.Finger@...inger.net>
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote:
> Rename the bit field element AdvCoding, as it causes a checkpatch issue
> with CamelCase naming. As the element is not actually used in code it
> has been renamed to 'not_used_adv_coding'.
> 
> The single line of code which initialises the bit has been removed,
> as the  field is unused.
> 
> This is a purely coding style change which should have no impact
> on runtime code execution.

Hi John.

Other than the somewhat useful code style cleanups, is there
a point at which you will feel comfortable doing actual code
changes to this driver?

Perhaps support for the chipset could be converted to use
mac80211 and moved into the directory with the other realtek
drivers in drivers/net/wireless/realtek/rtl8xxxu/...

Larry?  What do you think?