linux-kernel - Re: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2b7b914120f1c2e7020d18d7c7d824413e06304.camel@hpe.com>
Date:   Thu, 30 Aug 2018 21:29:04 +0000
From:   "Kani, Toshi" <toshi.kani@....com>
To:     "wufan@...eaurora.org" <wufan@...eaurora.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>
CC:     "baicar.tyler@...il.com" <baicar.tyler@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "james.morse@....com" <james.morse@....com>,
        "bp@...en8.de" <bp@...en8.de>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "john.garry@...wei.com" <john.garry@...wei.com>
Subject: Re: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

On Thu, 2018-08-30 at 18:37 +0000, Fan Wu wrote:
> For platforms whose firmwares provide valid module handles
> (SMBIOS type 17) in error records, this patch uses the module
> handles to locate corresponding DIMMs and enables per-DIMM
> error counter update.
> 
> Signed-off-by: Fan Wu <wufan@...eaurora.org>

Tested on an HPE x86 server. It turns out that mem_err->mem_dev_handle
was set to  0 with this FW, and get_dimm_smbios_index() returned -1. But
the code handles this case fine. dimm->smbios_handle's were initialized
properly. So:

Tested-by: Toshi Kani <toshi.kani@....com>

Thanks,
-Toshi