linux-kernel - RE: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001901d44099$fc8d7550$f5a85ff0$@codeaurora.org>
Date:   Thu, 30 Aug 2018 13:45:19 -0600
From:   "wufan" <wufan@...eaurora.org>
To:     "'Tyler Baicar'" <baicar.tyler@...il.com>
Cc:     <mchehab@...nel.org>, "'Borislav Petkov'" <bp@...en8.de>,
        "'James Morse'" <james.morse@....com>,
        <linux-edac@...r.kernel.org>,
        "'Linux Kernel Mailing List'" <linux-kernel@...r.kernel.org>,
        "'arm-mail-list'" <linux-arm-kernel@...ts.infradead.org>,
        <john.garry@...wei.com>, <toshi.kani@....com>
Subject: RE: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

Hi Tyler, 

> > +static int get_dimm_smbios_index(u16 handle) {
> > +       struct mem_ctl_info *mci;
> > +       int i;
> > +
> > +       mci = ghes_pvt->mci;
> > +
> 
> Minor nit: you could define and set mci in the same line to save some space
> here.
> 
> Otherwise this patch looks good to me.

Good catch Tyler! I'll fix it.

Thanks,
Fan

> Reviewed-by: Tyler Baicar <baicar.tyler@...il.com>