linux-kernel - Re: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABo9ajCui0y9HMBzgKWeNtrbu4de+mLh=d9Qdkyo4zhU9az6hw@mail.gmail.com>
Date:   Thu, 30 Aug 2018 15:18:04 -0400
From:   Tyler Baicar <baicar.tyler@...il.com>
To:     Fan Wu <wufan@...eaurora.org>
Cc:     mchehab@...nel.org, Borislav Petkov <bp@...en8.de>,
        James Morse <james.morse@....com>, linux-edac@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        arm-mail-list <linux-arm-kernel@...ts.infradead.org>,
        john.garry@...wei.com, toshi.kani@....com
Subject: Re: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

Hi Fan,

On Thu, Aug 30, 2018 at 2:37 PM, Fan Wu <wufan@...eaurora.org> wrote:
> For platforms whose firmwares provide valid module handles
> (SMBIOS type 17) in error records, this patch uses the module
> handles to locate corresponding DIMMs and enables per-DIMM
> error counter update.
>
> Signed-off-by: Fan Wu <wufan@...eaurora.org>

> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> index 473aeec..949f603 100644
> --- a/drivers/edac/ghes_edac.c
> +++ b/drivers/edac/ghes_edac.c
> @@ -81,6 +81,20 @@ static void ghes_edac_count_dimms(const struct dmi_header *dh, void *arg)
>                 (*num_dimm)++;
>  }
>
> +static int get_dimm_smbios_index(u16 handle)
> +{
> +       struct mem_ctl_info *mci;
> +       int i;
> +
> +       mci = ghes_pvt->mci;
> +

Minor nit: you could define and set mci in the same line to save some
space here.

Otherwise this patch looks good to me.

Reviewed-by: Tyler Baicar <baicar.tyler@...il.com>