linux-kernel - Re: [PATCH v2] riscv: Do not overwrite initrd_start and initrd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdV5_n=HqkBTZHZbpgzjoZD0_rmfxcT7GiGOpFxyZyiJ7A@mail.gmail.com>
Date:   Thu, 30 Aug 2018 11:00:47 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Palmer Dabbelt <palmer@...ive.com>, aou@...s.berkeley.edu,
        linux-riscv@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andreas Schwab <schwab@...ux-m68k.org>
Subject: Re: [PATCH v2] riscv: Do not overwrite initrd_start and initrd_end

Hi Guenter,

On Wed, Aug 29, 2018 at 2:34 AM Guenter Roeck <linux@...ck-us.net> wrote:
> setup_initrd() overwrites initrd_start and initrd_end if __initramfs_size
> is larger than 0, which is always true even if there is no embedded
> initramfs. This prevents booting qemu with "-initrd" parameter.
> Overwriting initrd_start and initrd_end is not necessary since
> __initramfs_start and __initramfs_size are used directly in

... since commit df52092f3c977885 ("fastboot: remove duplicate
unpack_to_rootfs()")...

To avoid -stable backporting this beyond v2.6.30 ;-)

> populate_rootfs() to load the built-in initramfs, so just drop
> that code.
>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds