linux-kernel - Re: [PATCH v2] riscv: Do not overwrite initrd_start and initrd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180831062006.GA18424@infradead.org>
Date:   Thu, 30 Aug 2018 23:20:06 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Palmer Dabbelt <palmer@...ive.com>,
        linux-riscv@...ts.infradead.org, Albert Ou <aou@...s.berkeley.edu>,
        schwab@...ux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] riscv: Do not overwrite initrd_start and initrd_end

On Tue, Aug 28, 2018 at 05:33:46PM -0700, Guenter Roeck wrote:
> setup_initrd() overwrites initrd_start and initrd_end if __initramfs_size
> is larger than 0, which is always true even if there is no embedded
> initramfs. This prevents booting qemu with "-initrd" parameter.
> Overwriting initrd_start and initrd_end is not necessary since
> __initramfs_start and __initramfs_size are used directly in
> populate_rootfs() to load the built-in initramfs, so just drop
> that code.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>