lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2018 07:40:10 -0700 From: Christoph Hellwig <hch@...radead.org> To: Palmer Dabbelt <palmer@...ive.com> Cc: linux-riscv@...ts.infradead.org, daniel.lezcano@...aro.org, jason@...edaemon.net, ard.biesheuvel@...aro.org, marc.zyngier@....com, catalin.marinas@....com, dmitriy@...-tech.org, jeremy.linton@....com, linux-kernel@...r.kernel.org, atish.patra@....com, aou@...s.berkeley.edu, Greg KH <gregkh@...uxfoundation.org>, tglx@...utronix.de Subject: Re: [PATCH 3/8] RISC-V: Rename riscv_of_processor_hart to riscv_of_processor_hartid > +/* Returns the hart ID of the given device tree node, or -1 if the device tree > + * node isn't a RISC-V hart. */ In addition to the comment formatting: we usually keep the description near the implementation, not the header. It could also become a kerneldoc comment for added clarity. > +extern int riscv_of_processor_hartid(struct device_node *node); No need to declare function prototypes in headers with the extern attribute, btw.
Powered by blists - more mailing lists