lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2018 10:51:09 -0500 From: Rob Herring <robh+dt@...nel.org> To: Johan Hovold <johan@...nel.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 1/9] of: add helper to lookup compatible child node On Mon, Aug 27, 2018 at 3:22 AM Johan Hovold <johan@...nel.org> wrote: > > Add of_get_compatible_child() helper that can be used to lookup > compatible child nodes. > > Several drivers currently use of_find_compatible_node() to lookup child > nodes while failing to notice that the of_find_ functions search the > entire tree depth-first (from a given start node) and therefore can > match unrelated nodes. The fact that these functions also drop a > reference to the node they start searching from (e.g. the parent node) > is typically also overlooked, something which can lead to use-after-free > bugs. > > Signed-off-by: Johan Hovold <johan@...nel.org> > --- > drivers/of/base.c | 25 +++++++++++++++++++++++++ > include/linux/of.h | 8 ++++++++ > 2 files changed, 33 insertions(+) I've applied this one and plan to send to Linus tomorrow. Rob
Powered by blists - more mailing lists