lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Aug 2018 00:09:34 +0800 From: Gao Xiang <hsiangkao@....com> To: Pavel Zemlyanoy <zemlyanoy@...ras.ru> Cc: Gao Xiang <gaoxiang25@...wei.com>, Chao Yu <yuchao0@...wei.com>, ldv-project@...uxtesting.org, devel@...verdev.osuosl.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, linux-erofs@...ts.ozlabs.org Subject: Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison Hi Pavel, On 2018/8/30 23:13, Pavel Zemlyanoy wrote: > This patch does not change the logic, it only > corrects the formatting and checkpatch checks by > to NULL comparison. > > The patch fixes 5 checks of type: > "Comparison to NULL could be written". > > Signed-off-by: Pavel Zemlyanoy <zemlyanoy@...ras.ru> Sorry about the late reply. I am on vacation now. Personally, I use "== NULL" or "!= NULL" on purpose, since it is more emphasized than the checkpatch.pl suggested way, and I tend to use the nullptr explicitly. BTW, It seems other filesystems still use "== NULL" or "!= NULL" explicitly, too, eg: xfs, ext4, ext2, ocfs2, etc... You could 'grep' in the fs directory... Other commits look good for me at glance. Thanks, Gao Xiang
Powered by blists - more mailing lists